Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Fix $costresource research #245

Merged
merged 1 commit into from Aug 15, 2016
Merged

Fix $costresource research #245

merged 1 commit into from Aug 15, 2016

Conversation

Jbaukens
Copy link
Contributor

@Jbaukens Jbaukens commented Aug 6, 2016

Fix the price of the research

Fix the price of the research
@bornhaeusser
Copy link

Now i think it is wrong.
The Cost was the cost from the next level.

@Jbaukens
Copy link
Contributor Author

Jbaukens commented Aug 8, 2016

Not really, use the $costresource on a blank page with a echo you will see you will not get the same amount as its would be expected, this fix the problem. if you use default code, to build level 9 it will ask you the price for the level 8 (that is already build on the planet or maybe in the queu list).
This does fix that issue

Regards

@sp33d86
Copy link

sp33d86 commented Aug 9, 2016

Also, I think it was fixed wrong here like in case of the buildings.
Again I'm comparing to the original OGame (here without fix):
image
image
Formula from owiki.de:
image
All correct without fix...

@Jbaukens
Copy link
Contributor Author

Jbaukens commented Aug 9, 2016

Hello don't try to understand or say its not true lol, @jkroepke comfirmed the issue and this is a real problem, i am working on this since years, i will not open a pull request if not needed, it has been tested, validated, and comfirmed, with different type of forumlas outside and inside 2moons

If you want to be sure, echo the resource on the overview page from the building in queu and echo the resource on the building page, you will see about what we are talking in here

=> #240
BUG : http://hpics.li/17b338f
NOT BUG: http://hpics.li/6c42226

Same building, Same level, different costresource as its false at the building and research page, its correct on overview pge

Regards
Hilarious

@sp33d86
Copy link

sp33d86 commented Aug 9, 2016

Haha, no need to be offensive. I may try to understand whenever I like to, dude! Just relax and calm down.
Also, what I just said was, that with the fix applied, the price for the research was the price for the correct level +1. Just a fact. Without it applied it was just like in the original OGame. Also just a fact.
I only wanted to help and I find your reaction kind of "hilarious" (pun intended)...
So long... and thanks for all the fish. ;)

@jkroepke
Copy link
Owner

See #241 for more informations. This pull request needs to be merged, if I changes the values in the database.

@Jbaukens
Copy link
Contributor Author

yes for sure, you need to review all values in database to have again same values as the real ogame, but atleasy the game wil have a bug less, thats the main case, if you want i post you new values in the install file.

Regards

@jkroepke
Copy link
Owner

We need a upgrade/migration path for current games.

@jkroepke
Copy link
Owner

Lets track this issue in #241 I hate to comment both pull requests.

@Jbaukens
Copy link
Contributor Author

Closed #241
yes whatever you want to name it, i have to do it for my game, so i will post a script this weekend here to

@Jbaukens Jbaukens closed this Aug 11, 2016
@jkroepke jkroepke reopened this Aug 11, 2016
@jkroepke jkroepke merged commit 8174dea into jkroepke:master Aug 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants