Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #442

Merged
merged 9 commits into from
Mar 11, 2024
Merged

fix tests #442

merged 9 commits into from
Mar 11, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (2bc81bd) to head (ad5a71c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files          23       23           
  Lines         856      856           
=======================================
  Hits          741      741           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -x' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- tests/lib/setup_suite.bash.orig
+++ tests/lib/setup_suite.bash
@@ -94,7 +94,7 @@
 }
 
 teardown_suite() {
-set -x
+    set -x
     {
         "${GPGCONF_BIN}" --kill gpg-agent >&2 || true
     } >&2
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -x' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- tests/lib/setup_suite.bash.orig
+++ tests/lib/setup_suite.bash
@@ -98,10 +98,9 @@
         set -x
         "${GPGCONF_BIN}" --kill gpg-agent
 
-        
         tasklist
     } >&2
-    
+
 }
 
 helm_plugin_install() {
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -x' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- tests/lib/setup_suite.bash.orig
+++ tests/lib/setup_suite.bash
@@ -98,10 +98,9 @@
         set -x
         "${GPGCONF_BIN}" --kill gpg-agent
 
-        
         tasklist
     } >&3
-    
+
 }
 
 helm_plugin_install() {
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -x' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- tests/lib/setup_suite.bash.orig
+++ tests/lib/setup_suite.bash
@@ -97,10 +97,10 @@
     {
         "${GPGCONF_BIN}" --kill gpg-agent
 
-        ps aux 
+        ps aux
         tasklist
     } >&3
-    
+
 }
 
 helm_plugin_install() {
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -x' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- tests/lib/setup_suite.bash.orig
+++ tests/lib/setup_suite.bash
@@ -102,7 +102,7 @@
 
         ps aux
     } >&3
-    
+
 }
 
 helm_plugin_install() {
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke changed the title debug fix tests Mar 11, 2024
@jkroepke jkroepke merged commit 855801a into main Mar 11, 2024
15 checks passed
@jkroepke jkroepke deleted the debug branch March 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant