Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt losses to automatically use correct device #23

Closed
einbandi opened this issue Jul 19, 2022 · 2 comments
Closed

Adapt losses to automatically use correct device #23

einbandi opened this issue Jul 19, 2022 · 2 comments

Comments

@einbandi
Copy link
Collaborator

Device-related errors are fixed in most places, but they remain a problem with the current loss implementation. The losses should know whether the model of a ParametricDR lives on CPU or GPU and move the .sub output accordingly.
einbandi added a commit that referenced this issue Jul 21, 2022
@einbandi
make loss device-aware (partial fix for #23)
e88d88b
@einbandi
Copy link
Collaborator Author

This is mostly done. There remains a RuntimeError when a model parameter is used inside a transform, but I couldn't figure out yet if this issue is connected with the loss modifications.

@einbandi
Copy link
Collaborator Author

Issue is fixed, the RuntimeError is caused by an in-place operation in the StudentTTransform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@einbandi