Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write method to register dataset #5

Closed
einbandi opened this issue Jul 5, 2022 · 0 comments
Closed

Write method to register dataset #5

einbandi opened this issue Jul 5, 2022 · 0 comments

Comments

@einbandi
Copy link
Collaborator

einbandi commented Jul 5, 2022

Think about whether it matters when the dataset is registered (before or after defining the training phases).

I think that a validity check of keys for accessing batch attributes is only possible for the pre-defined loss types, which have keyword parameters to set the keys. The values of these could be checked on the dataset and wppropriate warnings/error could be created. These checks can be performed regardless of definition order before the training, by iterating once over all the pre-defined losses in the phases.

einbandi added a commit that referenced this issue Jul 8, 2022
@einbandi einbandi moved this from To do to Done in Implement base functionality Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant