Changes required to pass on macOS without dirtying the repo #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/changes-required-to-pass-on-macos-without-dirtying-the-repo
branch
from
78dd188
to
d3aa5e3
Compare
jku
approved these changes
Mar 21, 2024
| @@ -132,7 +132,7 @@ def all_targets(self) -> Iterator[Tuple[str, Targets]]: | |||
|
|
|||
| @staticmethod | |||
| def create_key() -> Tuple[Key, SSlibSigner]: | |||
| key = generate_ed25519_key() | |||
| key = generate_ecdsa_key() | |||
There was a problem hiding this comment.
We shouldn't actually be using methods from the securesystemslib.keys module anymore ... but that is an issue in the code already so no need to fix here. I filed #14 for that.
|
We could add a github actions matrix to test on both macos and linux as well... but I'll merge this one now |
segiddins
deleted the
segiddins/changes-required-to-pass-on-macos-without-dirtying-the-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.