Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest filename with newline #2

Closed
edsu opened this issue Apr 14, 2014 · 0 comments
Closed

manifest filename with newline #2

edsu opened this issue Apr 14, 2014 · 0 comments

Comments

@edsu
Copy link
Contributor

edsu commented Apr 14, 2014

Over in the bagit-python repository we had a issue opened regarding a validation error for a newly created bag. The issue was tracked down to filenames that had an embedded carriage return (0x0d) in them, which made their way into the manifest, and ultimately disrupted validation.

One approach would be to prevent the creation of bags with filenames that have embedded CR, LF or CRLF. This would involve throwing an exception or error during bag creation. Another would be to allow these filenames to exist in the manifest, but to take care to encode them in such a way that doesn't disturb the line oriented format of the manifest.

I think it's in the spirit of BagIt to do the latter, accepting that some filesystems allow CR, LF and CRLF to be present in the filename.
@jkunze jkunze closed this as completed in 152d42f Apr 14, 2014
jkunze added a commit that referenced this issue Apr 14, 2014
@jkunze
Merge pull request #3 from edsu/crlf-in-filename
8fcae26 
small update about percent encoding cr, lf and crlf. fixes #2
@edsu edsu mentioned this issue Apr 15, 2014
Closed
acdha referenced this issue in LibraryOfCongress/bagit-spec Jun 6, 2017
@acdha
Remove Bag-Size from example bag-info.txt
56c069e 
This field is not specified but its presence in the examples can cause
confusion that it's a standard field. Since any app which needs a
human-formatted total file size may trivially calculate it from the
Payload-Oxum (also see #2) or filesystem metadata this commit removes it
to avoid confusion or the implication that tools must maintain the
value.
stain pushed a commit to stain/bagitspec that referenced this issue Apr 20, 2018
@johnscancella
refs jkunze#2 - added language to specify that all files must be in a…
f4d5911 
…ll manifests starting with version 1.0
stain pushed a commit to stain/bagitspec that referenced this issue Apr 20, 2018
@johnscancella
refs jkunze#2 - fixing grammer
4a8e2a3
stain pushed a commit to stain/bagitspec that referenced this issue Apr 23, 2018
@johnscancella
refs jkunze#2 - changed text to be more clear that the previous versi…
7bc88cc 
…on is just a note
@pwinckles pwinckles mentioned this issue Feb 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edsu