fix(observer): mapActions should be mapped into 'methods' for component

jkzing · Nov 14, 2017 · 59e387c · 59e387c
1 parent 80f6701
commit 59e387c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/observer.js b/src/observer.js
@@ -32,7 +32,7 @@ function reactionFn(mapState) {
   this.setData(mapped);
 }
 
-function startMobxReaction(mapState, mapActions) {
+function startMobxReaction(mapState, mapActions, isComponent) {
   const store = StoreMgr.getStore();
   Object.defineProperty(this, '$store', {
     enumerable: false,
@@ -46,11 +46,12 @@ function startMobxReaction(mapState, mapActions) {
   }
 
   if (mapActions) {
+    const actionMount = isComponent ? this.methods = this.methods || {} : this;
     let actions = mapActions(store, this.data) || {};
     Object.keys(actions).forEach(name => {
-      warning(this[name] !== undefined, 'Trying to overwrite an existing property.');
+      warning(actionMount[name] !== undefined, 'Trying to overwrite an existing property.');
       assert(typeof actions[name] === 'function', 'Actions can only be function.');
-      this[name] = actions[name];
+      actionMount[name] = actions[name];
     });
   }
 }
@@ -85,7 +86,7 @@ export default function observer(mapState, mapActions) {
     } else {
       const { onLoad, onUnload } = options;
       opts.onLoad = function() {
-        startMobxReaction.call(this, mapState, mapActions);
+        startMobxReaction.call(this, mapState, mapActions, isComponent);
 
         /* istanbul ignore else */
         if (typeof onLoad === 'function') {

diff --git a/src/utils.js b/src/utils.js
@@ -5,7 +5,7 @@ export function assert(condition, message) {
 
 export function warning(condition, message) {
   /* istanbul ignore else */
-  if (!condition) {
+  if (condition) {
     console.warn(`[mobx-weapp]: ${message}`);
   }
 }
diff --git a/test/utils.spec.js b/test/utils.spec.js
@@ -12,7 +12,7 @@ describe('utils', () => {
         }).toThrow();
     });
     it('warn in console when warning condition fails', () => {
-        warning(false, '');
+        warning(true, '');
         expect(console.warn).toHaveBeenCalled();
     });
 });