Add m2m history #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: simple_history/__init__.py simple_history/admin.py simple_history/models.py simple_history/tests/models.py simple_history/tests/tests/test_models.py
The old code blows up because source_field_name remains None. To test this:
Create a model that inherits from User:
class Employee(User):
pass
And an admin that also inherits UserAdmin:
class EmployeeAdmin(UserAdmin):
pass
site.register(Employee, EmployeeAdmin)
Add it to your settings and then go add an employee through it. Adding works fine. The change view is displayed after adding. Fill in the email or something and then save and it will blow up. The reason is because instance is the Employee model which inherits. It is an instance of User but it is not the same type.
Conflicts: simple_history/__init__.py simple_history/models.py
… using Django 1.9. Fixes #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.