Configurable Session Class #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 30, 2015 15:51
# Conflicts: # .gitignore # pynamodb/connection/base.py # pynamodb/models.py # pynamodb/tests/test_model.py # pynamodb/tests/test_table_connection.py # pynamodb/throttle.py
This is useful for tweaking the ConnectionPool size
| if session_cls: | ||
| self.session_cls = session_cls | ||
| else: | ||
| self.session_cls = requests.Session |
There was a problem hiding this comment.
Any reason not to default to this in the param?
There was a problem hiding this comment.
Ah I see, None can be passed
|
I was going to do this myself! +1 from me |
|
Any other optimizations you can think of to the session other than increasing the connection pool size? |
|
I'd have to think on that a bit more. We're actually standing up an egress proxy local to each application server to handle connections to external services. I'll let you know what we learn from that in a couple of weeks. |
|
@jlafon any thoughts |
|
@danielhochman hows that egress proxy working? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful for overriding the size of the Connection Pool and other Session fields.