Fix Unknown warning message

Directly show stdout/stderr of helm template command output
jlandowner · Apr 9, 2024 · d500fad · d500fad
1 parent 3d877fd
commit d500fad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/pkg/unstructured/__snapshots__/suite_test.snap b/pkg/unstructured/__snapshots__/suite_test.snap
@@ -264,12 +264,7 @@ SnapShot = """
 SnapShot = """
 WARN: failed to recognize a resource in stdout/stderr of helm template command output. snapshot it as Unknown: 
 ---
-object:
-    apiVersion: helm-chartsnap.jlandowner.dev/v1alpha1
-    kind: Unknown
-    raw: |-
-        some: raw data
-        raw:
-          data: here
-
+some: raw data
+raw:
+  data: here
 ---"""
diff --git a/pkg/unstructured/unknown.go b/pkg/unstructured/unknown.go
@@ -5,7 +5,6 @@ import (
 
 	metaV1 "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
-	yaml "sigs.k8s.io/yaml/goyaml.v3"
 )
 
 var (
@@ -22,11 +21,7 @@ type UnknownError struct {
 }
 
 func (e *UnknownError) Error() string {
-	out, err := yaml.Marshal(e.Unstructured())
-	if err != nil {
-		panic(err)
-	}
-	return fmt.Sprintf("WARN: failed to recognize a resource in stdout/stderr of helm template command output. snapshot it as Unknown: \n---\n%s\n---", out)
+	return fmt.Sprintf("WARN: failed to recognize a resource in stdout/stderr of helm template command output. snapshot it as Unknown: \n---\n%s\n---", e.Raw)
 }
 
 func (e *UnknownError) Unstructured() *metaV1.Unstructured {