New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Warning - Possible loss of data - Assigning zeros #84

Closed

J-Light opened this issue Jun 17, 2018 · 1 comment

Contributor

J-Light commented Jun 17, 2018

VS2015 warns of possible loss of data when assigning a zero value as the value is always int and converted to float or double.

An easy fix would be to make the following changes to findNeighbors function

auto zero = static_cast<decltype(result.worstDist())>(0);
assign(dists, (DIM > 0 ? DIM : BaseClassRef::dim), zero); // Fill it with zeros.

The text was updated successfully, but these errors were encountered:

J-Light mentioned this issue

Fix VS warning for casting int to float or double #85

Merged

Owner

jlblancoc commented Jun 19, 2018

Closed after #85

jlblancoc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment