Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chadwick register access #309

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

bdilday
Copy link
Contributor

@bdilday bdilday commented Jan 29, 2023

Updates the reading of the chadwick register from read people files from the chadwickbureau. The register has changed file format from one file containing all people, to several files, e.g. people-0.csv.

This PR updates code to

  • load the zip archive of chadwickbureau/register
  • search the zip archive for people*.csv
    • instead of assuming path people.csv
  • read them all into a dataframe

closes #308

@schorrm
Copy link
Collaborator

schorrm commented Jan 31, 2023

LGTM

@tjburch
Copy link
Collaborator

tjburch commented Feb 12, 2023

@bdilday can you re-up with master again to get the test updates from #318?

@tjburch
Copy link
Collaborator

tjburch commented Feb 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants