Updating FanGraphs leaderboard URL #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so sorry, not great at this yet. How do I implement this update? I even uninstalled (pip3 uninstsall pybaseball) and reinstalled and continue to get an empty dataframe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this blog post, FanGraphs has changed their leaderboard page, and moved the old leaderboard table to a new URL: https://www.fangraphs.com/leaders-legacy.aspx
According to the blog post, the legacy URL will work until the end of the 2023 season. So this is just a temporary fix until the refactor for the new leaderboard page.