Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statcast cache incomplete issue #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Statcast cache incomplete issue #379

wants to merge 2 commits into from

Conversation

ss77995ss
Copy link

Related Issue

Description

  • Cache with statcast function will have incorrect value and cause cache.purge() not work.
  • Also will cause the cache has no expire time and occupied in memory.

What cause this issue

  • If df_cache is wrapped by another df_cache the parent cache will finish writing once the child cache start writing.
  • Parent cache file will become invalid JSON file and cannot be parsed correctly.

How to fix

  • Remove the df_cache for _small_request

@ss77995ss ss77995ss changed the title Bugfix: Statcast cache incomplete issue Issue #375: Statcast cache incomplete issue Aug 20, 2023
@ss77995ss ss77995ss changed the title Issue #375: Statcast cache incomplete issue Statcast cache incomplete issue Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ss77995ss