Skip to content

Commit

Permalink
Merge pull request #33 from jnphilipp/fix-notifications
Browse files Browse the repository at this point in the history 
Default in getenv needs to be str not bool.
  • Loading branch information
@jle64
jle64 committed Oct 7, 2022
2 parents 6dc3328 + 2ced9fe commit 8a97303
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gnome-pass-search-provider.py
View file
Expand Up @@ -68,7 +68,7 @@ def __init__(self):
self.password_mode = getenv("PASSWORD_MODE") or "pass"
self.clipboard_executable = getenv("CLIPBOARD_EXECUTABLE") or "wl-copy"
self.disable_notifications = (
getenv("DISABLE_NOTIFICATIONS", False).lower() == "true"
getenv("DISABLE_NOTIFICATIONS", "false").lower() == "true"
)

@dbus.service.method(in_signature="sasu", **sbn)
Expand Down

3 comments on commit 8a97303

@spectrapulse
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the Copr project be updated so this change is included? Currently on Fedora 36 the latest Copr has this issue still present. It would avoid any issues being created related to this as currently the provider will crash on start without this set in env.

@jle64
Copy link
Owner Author

@jle64 jle64 commented on 8a97303 Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this @spectrapulse.

I've manually triggered a new build of the package on copr. This should be automatic but for whatever reason that doesn't seem to work any more.

I've no idea how much time it takes between the build and the actual update of the package in the repo but it's not instant as I just tried it and still got the old package files. Hopefully just waiting a bit should fix it.

@jle64
Copy link
Owner Author

@jle64 jle64 commented on 8a97303 Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good now.

Please sign in to comment.