Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use numeric IDs for items #9

Open
perimosocordiae opened this issue Apr 20, 2012 · 3 comments
Open

Use numeric IDs for items #9

perimosocordiae opened this issue Apr 20, 2012 · 3 comments

Comments

@perimosocordiae
Copy link
Collaborator

ala Minecraft. This would allow the name attribute to be used for a more descriptive String.
@perimosocordiae
Copy link
Collaborator Author

I've gotten started on this, but there's a bit more work to be done. Relevant commits are:
a3d59ea
6d8b610
9748590
59e6c5c

@jleahey
Copy link
Owner

jleahey commented Dec 30, 2012

How did you chose the particular ints for the ids?

@perimosocordiae
Copy link
Collaborator Author

Right now, the ints are the ASCII character codes that the single-character names used to be. That's still necessary while this code is being used, but hopefully that will get cleaned up soon. 💇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@perimosocordiae @jleahey