Skip to content

Commit

Permalink
io.podman.socket: drop Also=multi-user.target
Browse files Browse the repository at this point in the history
Using `Also=` means that the target unit will also be
installed/uninstalled together with our unit. Doing
`Also=multi-user.target` essentially says: disable `multi-user.target`
if `io.podman.socket` is disabled, which sounds... not at all like
what we want.

In practice, systemd thankfully ignores this (likely because it's the
default target). I think having `Also=io.podman.socket` in the
`io.podman.service` already does what we want here: it gets installed
under `sockets.target` whenever the service is. (And the fact that
systemd ignored this means that it wasn't actually playing a role in
resolving containers#3998.)

This was causing `systemctl preset-all` to dump core in Fedora CoreOS:
coreos/fedora-coreos-tracker#290

(Likely there's a systemd bug around here too.)

Signed-off-by: Jonathan Lebon <jonathan@jlebon.com>
  • Loading branch information
jlebon committed Oct 8, 2019
1 parent c817ea1 commit 59353b4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion contrib/varlink/io.podman.socket
Expand Up @@ -8,4 +8,3 @@ SocketMode=0600

[Install]
WantedBy=sockets.target
Also=multi-user.target

0 comments on commit 59353b4

Please sign in to comment.