Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the card is discarded, it will enter the Zone.GRAVEYARD #462

Closed
shinoi2 opened this issue Jul 27, 2018 · 3 comments
Closed

When the card is discarded, it will enter the Zone.GRAVEYARD #462

shinoi2 opened this issue Jul 27, 2018 · 3 comments

Comments

@shinoi2
Copy link
Collaborator

shinoi2 commented Jul 27, 2018

when a card is milled, it should move to Zone.REMOVEDFROMGAME or Zone.SETASIDE
when a card is discarded, "Cruel Dinomancer"(UNG_830) need a way to select them.

@tonyyyye
Copy link
Contributor

tonyyyye commented Jul 31, 2018

Yes I think you are right. The GRAVEYARD should store and only store all the DEAD minion, or the Resurrect BRM_017 will have a wrong choice range.

I tested with EX1_306 which justified my guess.

now the discard() is working in card.py

  1. log()
  2. set tags -> DISCARDED
  3. set Zone -> GRAVEYARD

so if a card is discarded, it has tags(or method called) like wisp.discarded() which has a True value.

@jleclanche
Copy link
Owner

The problem is there is no such thing as the DISCARD zone, that was something I added later on. Hearthstone tracks a graveyard zone separately... we don't mimick that at this time. I dunno what to do about it.

@tonyyyye
Copy link
Contributor

tonyyyye commented Aug 1, 2018

luckily we had preserved game.current_player.discarded. Maybe from this we can do something about it.
When discarded, append this card to game.current_player.discarded[], or select/filter the ones that has method of discarded().

Also, if the mechanism 'discarded card always goes into graveyard' does not change, the Resurrect and its related cards needs modification.

shinoi2 added a commit to play-boardgames-together/fireplace-core that referenced this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants