Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing a PR to fix a few small typos #489

Closed
timgates42 opened this issue Jun 8, 2021 · 0 comments · Fixed by #491
Closed

Proposing a PR to fix a few small typos #489

timgates42 opened this issue Jun 8, 2021 · 0 comments · Fixed by #491

Comments

@timgates42
Copy link
Contributor

Issue Type

[x] Bug (Typo)

Steps to Replicate and Expected Behaviour

  • Examine fireplace/dsl/evaluator.py and observe evalutae, however expect to see evaluate.
  • Examine fireplace/actions.py and observe destory, however expect to see destroy.
  • Examine tests/test_wog.py and observe bizzare, however expect to see bizarre.

Notes

Semi-automated issue generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

To avoid wasting CI processing resources a branch with the fix has been
prepared but a pull request has not yet been created. A pull request fixing
the issue can be prepared from the link below, feel free to create it or
request @timgates42 create the PR. Alternatively if the fix is undesired please
close the issue with a small comment about the reasoning.

https://github.com/timgates42/fireplace/pull/new/bugfix_typos

Thanks.

shinoi2 added a commit that referenced this issue Jul 1, 2021
There are small typos in:
- fireplace/actions.py
- fireplace/dsl/evaluator.py
- tests/test_wog.py

Fixes:
- Should read `evaluate` rather than `evalutae`.
- Should read `destroy` rather than `destory`.
- Should read `bizarre` rather than `bizzare`.

Closes #489

Co-authored-by: Tim Gates <tim.gates@iress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant