Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mastercard MCC list #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

@jleclanche
Copy link
Owner

This is really good! Though I'm confused how you're sourcing this from mastercard if it's hosted on the new york government website -- where did you get the link from?

Two minor changes to make on the csv itself:

  • Ensure there is a newline at EOL (it's failing lint because of it)
  • Please change the first line to MCC,DESCRIPTION to be consistent with the other CSVs

Thank you!

@SavingFrame
Copy link
Author

SavingFrame commented Dec 30, 2023

Updated. I added newline at the end of file and changed row description.
I just found xls on Google, added a little magic to get a csv and was done.
image

@jleclanche
Copy link
Owner

Got it. thank you. Let me try to figure out what the actual original source is before landing it then.

@jleclanche
Copy link
Owner

FYI - I don't think this is specifically the mastercast list, so that's why I want to figure out where it's from.

The mastercard list is here: https://www.mastercard.us/content/dam/mccom/en-us/documents/rules/quick-reference-booklet-merchant-edition.pdf

You can see for example in your PR, 1740 is "Masonry, Stonework, Tile Setting, Plastering, Insulation Contractors", whereas the official PDF sets it as "Insulation, Masonry, Plastering, Stonework, and Tile Setting Contractors".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants