Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of note title from extracted annotations #141

Merged
merged 1 commit into from Mar 26, 2014
Merged

Allow customization of note title from extracted annotations #141

merged 1 commit into from Mar 26, 2014

Conversation

ptgolden
Copy link
Contributor

Adds the following four prefs to extensions.zotfile.pdfExtraction.*:

  • noteTitle: Custom title to be used for extracted annotations.
    Default is an empty string, which falls back to the
    extraction.noteTitle string built-in to ZotFile.
  • includeDateInNote: Boolean indicating whether the date should be
    included in the note's title. Default is false. Overrides
    the localeDateInNote pref.
  • noteTitleHtmlTagStart: start tag for note title. Default is <b>
  • noteTitleHtmlTagEnd: end tag for note title. Default is </b>

Adds the following four prefs to extensions.zotfile.pdfExtraction.*:

  *  noteTitle: Custom title to be used for extracted annotations.
     Default is an empty string, which falls back to the
     `extraction.noteTitle` string built-in to ZotFile.
  *  includeDateInNote: Boolean indicating whether the date should be
     included in the note's title. Default is false. Overrides
     the `localeDateInNote` pref.
  *  noteTitleHtmlTagStart: start tag for note title. Default is `<b>`
  *  noteTitleHtmlTagEnd: end tag for note title. Default is `</b>`
jlegewie added a commit that referenced this pull request Mar 26, 2014
Allow customization of note title from extracted annotations
@jlegewie jlegewie merged commit ca34057 into jlegewie:master Mar 26, 2014
@jlegewie
Copy link
Owner

Thanks. Looks good to me. I will test it now...

@jlegewie
Copy link
Owner

Sorry, I changed the settings again but I think the new format is more flexible. There are now four settings to format the note: formatNoteTitle, formatAnnotationNote, formatAnnotationHighlight, formatAnnotationUnderline. These four replace all tagopen etc settings.

@ptgolden
Copy link
Contributor Author

That's great! I was thinking of something similar but didn't want to change what you'd already done. I look forward to using these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants