Django 1.9 compatibility #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Django 1.9 it is no longer possible to run model imports in the root package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django 1.9b1, this module throws the error:
"django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet."
This is because it is no longer possible to run model imports in the root package (as specified in the Django 1.9 release notes: https://docs.djangoproject.com/en/1.9/releases/1.9/ ).
While the diff makes it look like a lot has changed in this commit, all I've actually done is move everything to models.py and leave init.py blank. I've tested this back to Django 1.5 and it does not break backwards compatibility.
Additionally, when Django 1.9 is released in December, version 1.7 will no longer receive security updates (as per Django's support policy: https://docs.djangoproject.com/en/1.8/internals/release-process/#supported-versions ). It would be helpful if there was a copy of this extension on pypi that is compatible with current supported versions of Django. Is there any plan to package up the current iteration (0.4?) and publish to pypi?
Download statistics on https://pypi.python.org/pypi/djorm-ext-pgtrgm/0.3 indicate that there is interest in the module and users are actively downloading the module from this channel.