Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

Add modularity and first steps to unit testing and CI #1

Closed
wants to merge 58 commits into from

Conversation

glenux
Copy link
Contributor

@glenux glenux commented Jul 26, 2018

Here are the changes i've made :

  • restructured and modularized your code in order to isolate the logical components
  • added a few additional environment variables and I isolated the use of process.env within a "config" module to make it easier to test the parameters and set default values
  • added some unit tests and Travis to check the behavior of the application

@jlelse
Copy link
Owner

jlelse commented Jul 28, 2018

Thank you! Will merge it, after I found out how to setup a travis account...

jlelse added a commit that referenced this pull request Jul 28, 2018
@jlelse jlelse closed this Jul 28, 2018
@jlelse
Copy link
Owner

jlelse commented Jul 28, 2018

Merged your changes! Thank you so much for your work and contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants