Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request for the Auto Ripper and Playlist Obfuscation #50

Open
kbareis opened this issue May 19, 2019 · 2 comments
Open

Feature Request for the Auto Ripper and Playlist Obfuscation #50

kbareis opened this issue May 19, 2019 · 2 comments

Comments

@kbareis
Copy link

kbareis commented May 19, 2019

There are some instances where a disc may use playlist obfuscation. If the disc has this "feature" there is more work that has to go into picking the right playlist based on the video segments being in the right order. More info at: https://www.makemkv.com/forum/viewtopic.php?t=14388

Would it be possible to add some code like what I have below to reduce the likelihood of filling up a drive? What I have below is just a small check to see if there are titles longer than an hour. If there are more than 5 titles that are over an hour, then the ripper kicks an exit command and requires manual intervention and does not eject the disc.

# Minimum title length in seconds
  TITLE_LENGTH="3600"

# Maximum titles allowed by if statement below
  TOTAL_ALLOWED_TITLES="5"

# Checking to see how many titles there are on the disk
  echo "Reading the new disk. This might take a few minutes."
  MATCHED_TITLES=$(makemkvcon --minlength="$TITLE_LENGTH" -r --decrypt --directio=true info disc:0 | grep TCOUNT | cut -d ":" -f2)
  echo "Found $MATCHED_TITLES titles that are more than $TITLE_LENGTH seconds long."

# If statement saying that if there are more than x titles to throw an error
  if [[ $MATCHED_TITLES -le $TOTAL_ALLOWED_TITLES ]]; then
    # Regular ripping mechanic
  else
    # Error messaging if there were more titles than allowed
    echo "ERROR! Config allows $TOTAL_ALLOWED_TITLES titles max but found $MATCHED_TITLES. Leave disk in tray until the movie can be manually ripped."
    exit 1
  fi
@jlesage
Copy link
Owner

jlesage commented May 26, 2019

I agree, this could be a good protection to add.

@RyanRoberts210
Copy link

Just discovered this problem yesterday with two back to back discs; Hell or High Water and then Deepwater Horizon. The second did cause it to kick and not do anything because it was going to exceed my available storage so that was good. The first though ran forever... I was also thinking that it could just add the total time of the playable content and if that exceeded x hours then it would kick... A final thought would be a semi-auto mode where it showed you what it would do and you could just click OK to continue, still fast, but not fully auto...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants