Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update taocl for chinese language #333

Merged
merged 1 commit into from
Jan 18, 2016
Merged

zh: update taocl for chinese language #333

merged 1 commit into from
Jan 18, 2016

Conversation

miuc
Copy link
Contributor

@miuc miuc commented Jan 6, 2016

  1. change curl target to 'https://raw.githubusercontent.com/jlevy/the-art-of-command-line/master/README-zh.md'
  2. fix chinese utf-8 encoding error by add iconv step.

commit id: ce77a04

@Psycho7
Copy link
Contributor

Psycho7 commented Jan 9, 2016

Interesting thing :)
this document indeed varies for different language. It's reasonable to change urls for the right ones.
@jlevy have a look at this

@Psycho7
Copy link
Contributor

Psycho7 commented Jan 9, 2016

For the 2nd thing you commit, there should be a space before '|' to maintain the code style. Right?

And would you mind placing a prefix before your title?
Like: zh: update taocl for chinese language
So that it can be easier for me to find and review your PR

@jlevy
Copy link
Owner

jlevy commented Jan 13, 2016

Sure, makes sense to me, as long as you both confirm it's working! Good to merge?

@jlevy jlevy changed the title update taocl for chinese language zh: update taocl for chinese language Jan 13, 2016
@Psycho7
Copy link
Contributor

Psycho7 commented Jan 15, 2016

@miuc Still there? Would you mind placing a space before | in line 322?

jlevy added a commit that referenced this pull request Jan 18, 2016
zh: update taocl for chinese language
@jlevy jlevy merged commit b71341d into jlevy:master Jan 18, 2016
@jlevy
Copy link
Owner

jlevy commented Jan 18, 2016

Merged. @miuc @Psycho7 feel free to update/fix further if desired! Thanks!

@miuc
Copy link
Contributor Author

miuc commented Jan 21, 2016

-- @miuc Still there? Would you mind placing a space before | in line 322?

sorry for my late, it's ok.

I already put space at line 322 in my master branch now.

seems @jlevy Merged this branch, it's that any way I can still update/fix this space to master, in this merge request? (if I remember there is an reopen selection or not)

I'm not always online, sorry >_<

@Psycho7
Copy link
Contributor

Psycho7 commented Jan 22, 2016

@miuc That's ok. Just make a PR 👍

@ghost ghost mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants