Remove some bad characters from previous commit. Causes PHP errors. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleyva
added a commit
that referenced
this pull request
May 27, 2015
Remove some bad characters from previous commit. Causes PHP errors.
|
Thanks Dan! I didn't notice that, next time I'll be more careful when integrating contributed code |
|
No worries - I have to admit I couldn't see the problem when looking at the
initial patch either - my head just saw those dashes as tabs until I looked
closer!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like a previous commit added some invalid characters... it failed our internal PHP Lint check. Those characters are real dashes - not tabs so it's completely invalid PHP.