Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires= 'line-profiler>=1.0b3' vs name = 'line_profiler' ? #5

Open
matkor opened this issue Oct 30, 2014 · 3 comments
Open

Comments

@matkor
Copy link

matkor commented Oct 30, 2014

Im not expert in pythoneggs stuff but I am facing problem not satisfied requirements for flask_debugtoolbar_lineprofilerpanel:

In https://github.com/rkern/line_profiler/blob/master/setup.py there is:
install_requires=[
'line-profiler>=1.0b3'

while in https://github.com/rkern/line_profiler/blob/master/setup.py there is:
setup(
name = 'line_profiler',

Should not install_requires be 'line_profiler>=1.0" not "line-profiler" ?

@jlfwong
Copy link
Owner

jlfwong commented Oct 30, 2014

Does changing it to "line-profiler" fix the problem for you?

@matkor
Copy link
Author

matkor commented Oct 31, 2014

"Does changing it to "line-profiler" fix the problem for you?"
No.
We had to change to "line_profiler" (with underscore) like:
sed -i 's/line-profiler>=1.0b3/line_profiler>=1.0/g' setup.py
to exactly match line_profiler name in setup.py.

@jlfwong
Copy link
Owner

jlfwong commented Oct 31, 2014

If you'd like to submit a pull request to make the fix, I can test it out locally and merge if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants