Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baseline tests 馃槗 #14

Closed
9 of 14 tasks
jlfwong opened this issue Apr 10, 2018 · 1 comment
Closed
9 of 14 tasks

Add baseline tests 馃槗 #14

jlfwong opened this issue Apr 10, 2018 · 1 comment
Labels
test automation

Comments

@jlfwong
Copy link
Owner

jlfwong commented Apr 10, 2018 •
edited

There are no unit tests for this repository yet!

Some of the areas that should be pretty easy to write tests for:

  • importFromChromeTimeline
  • importFromChromeCPUProfile
  • importFromStackprof
  • importFromBGFlameGraph
  • The methods of the Profile class
  • The methods of the Flamechart class
  • The LRUCache class
  • The Vec2 class
  • The AffineTransform class
  • The Rect class

Trickier tests that would require some form of visual diffing + a GPU (or CPU implementation of gl like headless-gl, but are otherwise pretty stable with well defined interfaces

  • ViewportRectangleRenderer
  • TextureRenderer
  • RectangleBatchRenderer
  • FlamechartRenderer

And then there's the matter of tests for the UI itself
@jlfwong jlfwong mentioned this issue May 29, 2018
Merged
jlfwong added a commit that referenced this issue May 29, 2018
@jlfwong
Integrate jest and add first test file (#51)
aee4534 
This sets up the first bit of test infrastructure to write and run unit tests on every PR

Related to #14 
Fixes #7
This was referenced May 30, 2018
Merged
Merged
Merged
Merged
jlfwong added a commit that referenced this issue May 30, 2018
@jlfwong
Add tests for importers (#56)
2207ff5 
This also fixes deep copy import for Instruments when copying from Instruments 7

Related to #14
@jlfwong
Copy link
Owner Author

jlfwong commented Aug 8, 2018

Splitting this into smaller tasks for easier digestion

@jlfwong jlfwong closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test automation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlfwong