-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't open browser in Windows #168
Comments
Hi @janpio, thanks for reporting this! I've done verrry close to zero testing on windows, so this doesn't particularly surprise me :) I'll try to find some time to investigate this on a Windows VM. Out of curiousity, which shell are running |
Yeah, it didn't really surprise me as well, so no harm done ;) I was using Cmder right now, that usually behaves a bite more like git bash or a macOS or Linux shell than Powershell or cmd.exe. But should work everywhere of course 🔫 |
Changing the line await opn(urlToOpen, {wait: false}) to |
@spillerrec Oh sweet, thanks for figuring that out. I'd accept a PR to switch packages & patch the bug if you're interested! |
I have created a PR here: #307 |
This should be fixed now on master thanks to @spillerrec, and will go out with the next release. No promises on when that's going to be, but hopefully sometime in the next week or two. |
This has now been released, so it should be fixed in |
Nothing happens.
Opening
file://C:\Users\Jan\AppData\Local\Temp\speedscope-1538089620601-55152.html
manually worked.The text was updated successfully, but these errors were encountered: