Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedscope is totally broken on retina displays #327

Closed
jlfwong opened this issue Nov 12, 2020 · 0 comments
Closed

speedscope is totally broken on retina displays #327

jlfwong opened this issue Nov 12, 2020 · 0 comments

Comments

@jlfwong
Copy link
Owner

jlfwong commented Nov 12, 2020

Something in #323 is causing the prod version of speedscope to totally crash.

I test every release, but didn't think there would be a retina-specific crash 😬

speedscope.074e1f5c.js:100 Uncaught RangeError: Maximum call stack size exceeded
    at t.get renderTargetWidthInPixels [as renderTargetWidthInPixels] (speedscope.074e1f5c.js:100)
    at onBeforeFrame (speedscope.074e1f5c.js:114)
    at speedscope.074e1f5c.js:100
    at Set.forEach (<anonymous>)
    at t.resize (speedscope.074e1f5c.js:100)
    at maybeResize (speedscope.074e1f5c.js:190)
    at onBeforeFrame (speedscope.074e1f5c.js:114)
    at speedscope.074e1f5c.js:100
    at Set.forEach (<anonymous>)
    at t.resize (speedscope.074e1f5c.js:100)
get renderTargetWidthInPixels @ speedscope.074e1f5c.js:100
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
maybeResize @ speedscope.074e1f5c.js:190
onBeforeFrame @ speedscope.074e1f5c.js:114
(anonymous) @ speedscope.074e1f5c.js:100
resize @ speedscope.074e1f5c.js:100
requestAnimationFrame (async)
requestFrame @ speedscope.074e1f5c.js:114
componentWillReceiveProps @ speedscope.074e1f5c.js:190
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
b @ speedscope.074e1f5c.js:2
D @ speedscope.074e1f5c.js:2
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
b @ speedscope.074e1f5c.js:2
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
b @ speedscope.074e1f5c.js:2
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
b @ speedscope.074e1f5c.js:2
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
C @ speedscope.074e1f5c.js:2
b @ speedscope.074e1f5c.js:2
N @ speedscope.074e1f5c.js:2
(anonymous) @ speedscope.074e1f5c.js:2
x @ speedscope.074e1f5c.js:2
Promise.then (async)
g @ speedscope.074e1f5c.js:2
y.setState @ speedscope.074e1f5c.js:2
u.__c.u.__ @ speedscope.074e1f5c.js:80
(anonymous) @ speedscope.074e1f5c.js:118
D @ speedscope.074e1f5c.js:80
(anonymous) @ speedscope.074e1f5c.js:80
(anonymous) @ speedscope.074e1f5c.js:80
o.options.__c @ speedscope.074e1f5c.js:80
U @ speedscope.074e1f5c.js:2
L @ speedscope.074e1f5c.js:2
parcelRequire.K5F6.preact @ speedscope.074e1f5c.js:194
f @ speedscope.074e1f5c.js:1
parcelRequire.aSor @ speedscope.074e1f5c.js:1
(anonymous) @ speedscope.074e1f5c.js:1
Show 170 more frames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant