Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file and line information #365

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

sokra
Copy link
Contributor

@sokra sokra commented Sep 27, 2021

  • add file and line to tooltips
  • add file and line to anonymous methods

Before:

image

image

While you was able to get this info with clicking in "Time Order" and "Left Heavy" view, it was impossible to receive in the sandwich view.

After:

image

image

@jlfwong
Copy link
Owner

jlfwong commented Sep 29, 2021

Hi @sokra! Thanks for all the work you've done towards building the modern JS ecosystem!

While you was able to get this info with clicking in "Time Order" and "Left Heavy" view, it was impossible to receive in the sandwich view.

Ahh, this is a good call out.

I think I'd rather see this approached slightly differently.

  1. Always include file & line number in the hovertip
  2. In the import codepath from Chrome which may have these (anonymous) frames, rename the symbol to also include the file & line number. The motivation for this is that speedscope imports from many formats, and (anonymous) is specific to Chrome profiles AFAIK.

What do you think?

@sokra
Copy link
Contributor Author

sokra commented Sep 30, 2021

What do you think?

Sounds good. I've updated the PR

@shadeMe
Copy link

shadeMe commented May 5, 2022

@jlfwong Any chance of merging this for the next release? Would be a welcome addition :)

@jlfwong jlfwong merged commit 1ac88cc into jlfwong:main May 17, 2022
jackerghan pushed a commit to jackerghan/speedscope that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants