-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Papyrus profiles (#427) #428
Conversation
Re-activated logging + more verbose messages
Everything works now. As I said, implementation could be more ideal if I could access |
Frames left on the stack were prolonged by <startValue> ms
I've noticed one more thing: In the time order view, you can't see the things that take under 1ms, because they count as 0ms, which makes them completely invisible. Calling those functions still takes time, though, as the calls sometimes can't execute instantly and are thus put on the queue instead. I will try to implement queues as frames that contain the function calls. |
Refactored variable naming to be more consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
A few small things that need revision, but this should be good to land afterwards
Implemented all suggested changes :) |
I had to change more than I anticipated, everything seems to be working as intended now. |
Hey @xieve -- just opened a test run, and it looks like CI is failing at the moment. You can see the issue here: https://github.com/jlfwong/speedscope/actions/runs/5317035811/jobs/9678064431?pr=428 It seems like the snapshots don't match -- can you take a look, update the snapshots, and make sure the changes are as expected? |
Damn, I forgot to commit the updated snapshots. |
Here's what I have so far. There are still a couple of issues:
sh: 1: ./scripts/test-setup.sh: not found
)Profile.totalWeight
but they still always start at 0Profile.stack
andProfile.frames
are protected, this way I have to re-implement those