Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when importing big linux perf tool files #435

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix crash when importing big linux perf tool files #435

merged 1 commit into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Fix crash when importing big linux perf tool files 

    Currently, importing files generated by linux perf tool whose some blocks exceed V8 strings limit can crash the application. This issue is similar to the one in jlfwong#385.

This PR fixes it by changing parseEvents to work directly with lines instead of chunking lines into blocks first.

Fixes jlfwong#433
    @Goose97
    Goose97 committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e1dacfe View commit details
    Browse the repository at this point in the history