Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callgrind parser: Fixed associating file names with symbols and detection of root nodes #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Callgrind parser: Fixed associating file names with symbols and detection of root nodes #466

wants to merge 1 commit into from

Commits on Mar 1, 2024

  1. import: callgrind.ts: Improved collection of file names associated wi… 

    …th functions

When called function is within an inlined code block, it should use file names
provided by 'fi' or 'fe' commands.

Also, when 'fn' command is called, it sets the current file name to the value
provided in the previous 'fl' call.

Also, the file associated with 'fn' should be stored separately so that
it is not overwritten by new 'fl' calls (Callgrind does not tell whether
there can be multiple 'fl' calls without following 'fn' calls, and this
should guard the parser from associating the wrong new file name with the
previous 'fn' function).

This modification fixes detached call stacks, which were created when one
function has been called from inline block without the file source update,
which led to duplicated entries, which were later not removed when
determining root functions.

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    20bc6ce View commit details
    Browse the repository at this point in the history