Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the "Table view" to a "Sandwich" view #73

Merged
merged 18 commits into from
Jun 29, 2018

Conversation

jlfwong
Copy link
Owner

@jlfwong jlfwong commented Jun 25, 2018

image

This provides information about the caller & callees of individual functions selected in the table view.

@coveralls
Copy link

coveralls commented Jun 25, 2018

Pull Request Test Coverage Report for Build 166

  • 48 of 562 (8.54%) changed or added relevant lines in 14 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 36.076%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flamechart-style.ts 0 1 0.0%
flamechart-minimap-view.tsx 0 2 0.0%
style.ts 0 4 0.0%
profile-table-view.tsx 0 5 0.0%
flamechart-renderer.ts 0 8 0.0%
application.tsx 0 13 0.0%
flamechart-view.tsx 0 14 0.0%
hovertip.tsx 0 19 0.0%
text-utils.ts 0 20 0.0%
flamechart-detail-view.tsx 0 33 0.0%
Files with Coverage Reduction New Missed Lines %
profile-table-view.tsx 1 0.0%
application.tsx 1 0.0%
flamechart-renderer.ts 1 0.0%
flamechart-view.tsx 2 0.0%
Totals Coverage Status
Change from base Build 154: -0.8%
Covered Lines: 1063
Relevant Lines: 2824

💛 - Coveralls

@jlfwong jlfwong force-pushed the jlfwong/focal-frame-flamechart branch from 137efba to 6a7aa99 Compare June 28, 2018 22:13
@jlfwong jlfwong merged commit 0e65480 into master Jun 29, 2018
@jlfwong jlfwong deleted the jlfwong/focal-frame-flamechart branch June 29, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants