Raise `ArgumentError` if `Version` is initialized with a `nil` version string #44

timrogers · 2022-04-22T12:36:56Z

At the moment, Semantic::Version.new raises a NoMethodError exception like this if you try to pass in nil as the version string:

undefined method `match' for nil:NilClass (NoMethodError)

v = version_str.match(SemVerRegexp)

This alters the behaviour to raise an ArgumentError instead, which is what we do if you pass a malformed string (e.g. dasd). This is a breaking change to the library's API - but it feels like a more reasonable and unsurprising behaviour.

…n string At the moment, `Semantic::Version.new` raises a `NoMethodError` exception like this if you try to pass in `nil` as the version string: ``` undefined method `match' for nil:NilClass (NoMethodError) v = version_str.match(SemVerRegexp) ``` This alters the behaviour to raise an `ArgumentError` instead, which is what we do if you pass a malformed string (e.g. `dasd`). This is a breaking change - but feels like a more reasonable and unsurprising behaviour.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise `ArgumentError` if `Version` is initialized with a `nil` version string #44

Raise `ArgumentError` if `Version` is initialized with a `nil` version string #44

timrogers commented Apr 22, 2022

Raise ArgumentError if Version is initialized with a nil version string #44

Are you sure you want to change the base?

Raise ArgumentError if Version is initialized with a nil version string #44

Conversation

timrogers commented Apr 22, 2022

Raise `ArgumentError` if `Version` is initialized with a `nil` version string #44

Raise `ArgumentError` if `Version` is initialized with a `nil` version string #44