Log exceptions caught during completion, fixes #115

jline · Apr 24, 2017 · aa22442 · aa22442 · jdillon · Apr 24, 2017
1 parent d52c65b
commit aa22442
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java b/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java
@@ -3716,19 +3716,28 @@ protected boolean doComplete(CompletionType lst, boolean useMenu, boolean prefix
             if (expandHistory()) {
                 return true;
             }
-        } catch (IllegalArgumentException e) {
+        } catch (Exception e) {
+            Log.info("Error while expanding history", e);
             return false;
         }
 
-        // Parse the command line and find completion candidates
-        List<Candidate> candidates = new ArrayList<>();
+        // Parse the command line
         ParsedLine line;
         try {
             line = parser.parse(buf.toString(), buf.cursor(), ParseContext.COMPLETE);
+        } catch (Exception e) {
+            Log.info("Error while parsing line", e);
+            return false;
+        }
+
+        // Find completion candidates
+        List<Candidate> candidates = new ArrayList<>();
+        try {
             if (completer != null) {
                 completer.complete(this, line, candidates);
             }
         } catch (Exception e) {
+            Log.info("Error while finding completion candidates", e);
             return false;
         }