Correctly close the NonBlockingReader to shutdown the reading thread

jline · Aug 30, 2017 · b94e9b9 · b94e9b9
1 parent 2003736
commit b94e9b9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/terminal/src/main/java/org/jline/terminal/impl/PosixPtyTerminal.java b/terminal/src/main/java/org/jline/terminal/impl/PosixPtyTerminal.java
@@ -67,6 +67,12 @@ public PrintWriter writer() {
         return writer;
     }
 
+    @Override
+    public void close() throws IOException {
+        super.close();
+        reader.close();
+    }
+
     private class InputStreamWrapper extends InputStream {
 
         private final InputStream in;

diff --git a/terminal/src/main/java/org/jline/terminal/impl/PosixSysTerminal.java b/terminal/src/main/java/org/jline/terminal/impl/PosixSysTerminal.java
@@ -93,6 +93,6 @@ public void close() throws IOException {
             Signals.unregister(entry.getKey().name(), entry.getValue());
         }
         super.close();
-        reader.shutdown();
+        reader.close();
     }
 }