New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs typo: `Columns separated` -> `Colon separated` #775

Merged

mattirn merged 1 commit into jline:master from mikesamuel:fix-typo-in-history-ignore-docs

Mar 18, 2022

Contributor

mikesamuel commented Mar 17, 2022

I believe "colon" was intended because HISTORY_IGNORE's value is
passed to matchPatterns which converts colons to Regex |.

jline3/reader/src/main/java/org/jline/reader/impl/history/DefaultHistory.java

Lines 402 to 403 in c6ae2c1

    
           } else if (ch == ':') { 
        
               sb.append('|');


          Docs typo: Columns separated -> Colon separated

db38593

I believe "colon" was intended because *HISTORY_IGNORE*'s value is
passed to `matchPatterns` which converts colons to Regex `|`.

https://github.com/jline/jline3/blob/c6ae2c1295c81893456a38ae69509693a690b50d/reader/src/main/java/org/jline/reader/impl/history/DefaultHistory.java#L402-L403

mattirn merged commit fe1a6ff into jline:master

mikesamuel deleted the fix-typo-in-history-ignore-docs branch

March 18, 2022 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment