Fix generate single sample with null value #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhyeon-lee Thanks for the catch. I cannot merge the PR, though, unless you add to the buttom of the PRs description. Thank you. |
|
@jlink I added agreement description. thank you |
|
@mhyeon-lee Many thanks! |
jlink
added a commit
that referenced
this pull request
Nov 26, 2020
luvarqpp
reviewed
Nov 26, 2020
| @@ -441,8 +441,10 @@ public boolean isUnique() { | |||
| @API(status = MAINTAINED, since = "1.3.0") | |||
| default T sample() { | |||
| return this.sampleStream() | |||
| .findFirst() | |||
| .orElseThrow(() -> new JqwikException("Cannot generate a value")); | |||
| .map(Optional::ofNullable) | |||
There was a problem hiding this comment.
I would be a little bit concerned about performance... On the other side, this method should not be called extensively. It is called only by user while experimenting, or perhaps from "normal" JUnit tests. Am I right?
|
To be frank I'm not concerned. When generating values so much is going on that the little bit of overhead through mapping should be neglectible. But I didn't measure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Arbitrary.samplethrows NullPointException when generating null values.Calling the
findFirstmethod on Stream does not allow null values.Details
To avoid handling null values, wrap it with Optional and handle it.
I hereby agree to the terms of the jqwik Contributor Agreement.