Adding fast-check to the shrinking challenge #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
changed the title
dubzzz
changed the title
dubzzz
commented
Jan 23, 2021
|
@dubzzz Sorry. I somehow missed the PR. Is it ready for merging from your POV? |
|
Yes, ready to be merged |
|
I'll certainly update the results with future releases of fast-check (mostly the calculator one where fast-check was not really efficient with current version). But it can be merged for now |
|
Many thanks for the great contribution, Nicolas!
Am Do., 28. Jan. 2021 um 19:57 Uhr schrieb Nicolas DUBIEN <
notifications@github.com>:
… I'll certainly update the results with future releases of fast-check
(mostly the calculator one where fast-check was not really efficient with
current version)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZMANSVTA4FY2NEJFF7FLS4GXQVANCNFSM4WP46U4A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jlink First of all, thanks a lot for this challenge. As promised a while ago, here is a new property based testing to enrich your challenge with more examples.
Please let me know if I should adapt things in the current PR.
Related to dubzzz/fast-check#899