Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious SBSettings HD icons #53

Merged
merged 4 commits into from Mar 15, 2012
Merged

Serious SBSettings HD icons #53

merged 4 commits into from Mar 15, 2012

Conversation

fopina
Copy link

@fopina fopina commented Mar 14, 2012

Wi-Fi toggle icon rotated to (try to) match WifiSMS original icon :)

@fopina
Copy link
Author

fopina commented Mar 15, 2012

binary removal from version control is just a suggestion as keeping those binaries screw up the commitdiff's :(
Also redid buildDEP.sh script to it will update automatically the version in DEBIAN/control', copy all the required binaries and replaced the hardcoded root path (~/WifiSMS) with SCRIPTPATH/.. (as script is in Build) :)

@fopina
Copy link
Author

fopina commented Mar 15, 2012

last commit on the pull request is to fix an actual bug:

  • on new incoming SMS phone was not going through "cleanPhone" so, sometimes, it would show up as a new conversation instead of match the proper one
  • cleanPhone (both in objC and javascript) did not check for "00" as international prefix (only covered "+" sign)
  • cleanPhone in JavaScript would never removed a country prefix with more than one digit...

Hope that's useful :)

treason added a commit that referenced this pull request Mar 15, 2012
Serious SBSettings HD icons
@treason treason merged commit 574df4f into jlippold:master Mar 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants