Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace @while loops with @for loops #60

Merged
merged 1 commit into from
Mar 31, 2013
Merged

Replace @while loops with @for loops #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions lib/_mixins.scss
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -578,16 +578,14 @@
} }


@mixin grid-core-span-x($gridColumns, $gridColumnWidth, $gridGutterWidth) { @mixin grid-core-span-x($gridColumns, $gridColumnWidth, $gridGutterWidth) {
@while $gridColumns > 0 { @for $i from 1 through $gridColumns {
.span#{$gridColumns} { @include grid-core-span($gridColumns, $gridColumnWidth, $gridGutterWidth)} .span#{$i} { @include grid-core-span($i, $gridColumnWidth, $gridGutterWidth)}
$gridColumns: $gridColumns - 1;
} }
} }


@mixin grid-core-offset-x($gridColumns, $gridColumnWidth, $gridGutterWidth) { @mixin grid-core-offset-x($gridColumns, $gridColumnWidth, $gridGutterWidth) {
@while $gridColumns > 0 { @for $i from 1 through $gridColumns {
.offset#{$gridColumns} { @include grid-core-offset($gridColumns, $gridColumnWidth, $gridGutterWidth); } .offset#{$i} { @include grid-core-offset($i, $gridColumnWidth, $gridGutterWidth); }
$gridColumns: $gridColumns - 1;
} }
} }


Expand Down Expand Up @@ -627,17 +625,15 @@
} }


@mixin grid-fluid-span-x($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth) { @mixin grid-fluid-span-x($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth) {
@while $gridColumns > 0 { @for $i from 1 through $gridColumns {
.span#{$gridColumns} { @include grid-fluid-span($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth); } .span#{$i} { @include grid-fluid-span($i, $fluidGridColumnWidth, $fluidGridGutterWidth); }
$gridColumns: $gridColumns - 1;
} }
} }


@mixin grid-fluid-offset-x($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth) { @mixin grid-fluid-offset-x($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth) {
@while $gridColumns > 0 { @for $i from 1 through $gridColums {
.offset#{$gridColumns} { @include grid-fluid-offset($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth); } .offset#{$i} { @include grid-fluid-offset($i, $fluidGridColumnWidth, $fluidGridGutterWidth); }
.offset#{$gridColumns}:first-child { @include grid-fluid-offset-first-child($gridColumns, $fluidGridColumnWidth, $fluidGridGutterWidth); } .offset#{$i}:first-child { @include grid-fluid-offset-first-child($i, $fluidGridColumnWidth, $fluidGridGutterWidth); }
$gridColumns: $gridColumns - 1;
} }
} }


Expand Down Expand Up @@ -675,13 +671,12 @@
} }


@mixin grid-input-span-x($gridColumns, $gridColumnWidth, $gridGutterWidth) { @mixin grid-input-span-x($gridColumns, $gridColumnWidth, $gridGutterWidth) {
@while $gridColumns > 0 { @for $i from 1 through $gridColumns {
input.span#{$gridColumns}, input.span#{$i},
textarea.span#{$gridColumns}, textarea.span#{$i},
.uneditable-input.span#{$gridColumns} { .uneditable-input.span#{$i} {
@include grid-input-span($gridColumns, $gridColumnWidth, $gridGutterWidth); @include grid-input-span($i, $gridColumnWidth, $gridGutterWidth);
} }
$gridColumns: $gridColumns - 1;
} }
} }


Expand Down