Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'shell' #220

Merged
merged 2 commits into from May 8, 2018
Merged

Error: Cannot find module 'shell' #220

merged 2 commits into from May 8, 2018

Conversation

macmedia
Copy link
Contributor

Environment

Mac OS 10.13.3 (High Sierra)
Electron - v1.8.4
Node - v9.8.0
nom - v5.6.0
Git-it - v4.3.3 (master)

Problem

When running the pre-built (v4.3.3 Mac-X64) or building it myself, I was getting a
Uncaught Exception:Error: Cannot find module 'shell'

Click on Help -> Repository menu and the error pops up.

I updated the darwin-menu.js to use shell.openExternal like its done with Help -> Open Issue. This has corrected the error and the url opens.

Error Message

Uncaught Exception:
Error: Cannot find module 'shell'
    at Module._resolveFilename (module.js:485:15)
    at Function.Module._resolveFilename (/Users/_user_/github/git-it-electron/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at click (/Users/_user_/github/git-it-electron/menus/darwin-menu.js:130:13)
    at MenuItem.click (/Users/_user_/github/git-it-electron/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/menu-item.js:52:9)
    at Function.executeCommand (/Users/_user_/github/git-it-electron/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/menu.js:34:15)

Add exrta space so 'standard' would pass the test.
@jlord
Copy link
Owner

jlord commented May 8, 2018

Thank you!! ✨

@jlord jlord merged commit 450f4ff into jlord:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants