Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐢 #55

Merged
merged 6 commits into from Sep 3, 2015
Merged

🐢 #55

merged 6 commits into from Sep 3, 2015

Conversation

muan
Copy link
Collaborator

@muan muan commented Sep 3, 2015

didn't pass section

image

tips section

image

file selection - more obvious warning

image

non visual changes

  • Fix clicking on verify twice without selecting a dir disables the verify button forever
  • Pulled out all JavaScript on challenge content to challenge.js since they're all the same and we can just update in one place.
  • Fix package.json missing a comma
  • Allow scrolling the challenge list when the window is too short

cc @jlord

@jlord
Copy link
Owner

jlord commented Sep 3, 2015

Nooooiiiiiiiiceee 🍕

Pulled out all JavaScript on challenge content to challenge.js since they're all the same and we can just update in one place.

Probably my favorite part, if I had to pick, cause I was just going through all of this and like "ughhhh" this needs to be it's own thing. I even put it in an issue. And now it's done! ❤️ ❤️

jlord pushed a commit that referenced this pull request Sep 3, 2015
@jlord jlord merged commit 98729eb into master Sep 3, 2015
@jlord jlord deleted the improvements branch September 3, 2015 05:19
@jlord jlord mentioned this pull request Sep 3, 2015
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants