Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show All" fails if search starts with capital letter #8

Closed
mshenfield opened this issue Mar 22, 2017 · 0 comments
Closed

"Show All" fails if search starts with capital letter #8

mshenfield opened this issue Mar 22, 2017 · 0 comments

Comments

@mshenfield
Copy link
Contributor

Search "Ci" (with a capital "C"):
screen shot 2017-03-21 at 7 01 53 pm

Clicking "Show Available" clears claimed items:
screen shot 2017-03-21 at 7 01 58 pm

Clicking "Show All" shows nothing:
screen shot 2017-03-21 at 7 02 02 pm

Searching with "ci" (lower case "c") "Show All" works as expected:
screen shot 2017-03-21 at 7 03 36 pm

@jlord jlord closed this as completed in 237c0dc Mar 22, 2017
mshenfield added a commit to mshenfield/lending-library that referenced this issue Mar 22, 2017
This replaces some of the toggling with a CSS class on the tools container, that when set, along with the `not-available` class on each item, set's their display property to `none`. When the button is pressed, this just toggles the container class as well.

This also updates the filtering logic to work with __SHOW AVAILABLE__. jQuery's `show` method adds inline style `display: block;`, overriding any previous logic. This again replaces jQuery's `show`/`hide` with a class, `filtered`, that is hidden with CSS.

A lot of jQuery code re-running filters, etc. get to be deleted! I'm not 100% sure splitting the display logic between the CSS/JS is a great idea though.

Closes jlord#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant