Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagerize everything #57

Open
ghost opened this issue Dec 6, 2010 · 2 comments
Open

Lagerize everything #57

ghost opened this issue Dec 6, 2010 · 2 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Dec 6, 2010

I'm working on polling servers for BEP5 at the moment and as I go along I add some code for logging the progress and stats of polls. This is useful to see while developing but not so much for a user to see while using the program.

It would be nice to be able to route all logging calls through a configurable logging module that is aware of which types of messages etorrent emits, in the same spirit as accesses to the application config is routed through etorrent_config in my config-module branch.

It wouldn't make any sense to export a function for each message type, just a simple interface in the lines of the following code would do:

 etorrent_log:info(dht_poll, "blalala ~w", [Term])
@jlouis
Copy link
Owner

jlouis commented Dec 6, 2010

Makes sense. Consider routing anything in log.hrl through it as well.

@jlouis
Copy link
Owner

jlouis commented Oct 13, 2012

This is still ongoing, but we should definitely be using lager all over the place rather than roll our own logging framework inside etorrent.

@ghost ghost assigned jlouis Oct 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant