Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PyCharm 2019.2 #15

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix for PyCharm 2019.2 #15

merged 1 commit into from
Aug 15, 2019

Conversation

aklajnert
Copy link
Contributor

@aklajnert aklajnert commented Jul 26, 2019

This PR fixes the plugin behavior with PyCharm 2019.2.
The handle_post_mortem_stop() method was removed and the plugin is crashing.

Closes #14.

pytest_pycharm.py Outdated Show resolved Hide resolved
pytest_pycharm.py Outdated Show resolved Hide resolved
@aklajnert aklajnert closed this Jul 26, 2019
@aklajnert aklajnert reopened this Jul 26, 2019
@youtux
Copy link

youtux commented Aug 13, 2019

This works quite well for me, @jlubcke do you plan to merge this?

@jlubcke jlubcke merged commit 361cdf0 into jlubcke:master Aug 15, 2019
@jlubcke
Copy link
Owner

jlubcke commented Aug 15, 2019

I merged and did a 0.6.0 release.

@jlubcke
Copy link
Owner

jlubcke commented Aug 15, 2019

Sorry about the slow response. Thanks a lot for the help!

@aklajnert aklajnert deleted the fix_pycharm_2019.2 branch August 16, 2019 15:14
@piotr-dobrogost
Copy link

There's no 0.6.0 release at https://github.com/jlubcke/pytest-pycharm/releases and there's no such tag either.

@jlubcke
Copy link
Owner

jlubcke commented Sep 20, 2019

My misstake. I managed to release to pypi, but somehow not pushing the tag to github. (Doing so made it turn up under releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with PyCharm 2019.2
4 participants