Removed invalid CBR option and channel layouts + added VBR option. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MP3] Added LAME's highest quality VBR option ('-V 0') and renamed the MP3 VBR options. The maximum bitrate with MP3 is 320k, so I have removed the 448k option. Also, MP3 does not support more than two channels.
Removed invalid CBR option and channel layouts + added VBR option.
|
I wanted to say thank you. I am going to delete the last commit and accept this pull request first thing in the morning. Im very new to this and I didn't mean to do that. I will definitely get this fixed! |
jessielw
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MP3] Added LAME's highest quality VBR option ('-V 0') and renamed the MP3 VBR options. The maximum bitrate with MP3 is 320k, so I have removed the 448k option. Also, MP3 does not support more than two channels.