Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django deprecations #12

Merged
merged 3 commits into from
Sep 9, 2013
Merged

Conversation

gthb
Copy link
Contributor

@gthb gthb commented Jul 13, 2013

Fixing some stuff I've encountered when running with scissors Django 1.5.1

@winhamwr
Copy link
Collaborator

With these changes, are things still kosher on Django 1.3? I don't actually ever use the Admin integration, myself.

@winhamwr
Copy link
Collaborator

And thanks for both of the pull requests :) I haven't gotten to use Django 1.5 on any real project yet, so I appreciate that some of this will be fixed for when I do.

@gthb
Copy link
Contributor Author

gthb commented Jul 30, 2013

Whoops, forgot to comment here (was traveling). Looks like these changes are not kosher on Django 1.3:

  • git log -Sadmin_static shows it being added in commit 1d32bdd3c9586ff10d0799264105850fa7e3f512
  • git tag --contains 1d32bdd3c9586ff10d0799264105850fa7e3f512 starts at 1.4

So I guess this should only be merged on a branch that abandons Django 1.3 compatibility (or else this should be improved to stay compatible).

jezdez added a commit that referenced this pull request Sep 9, 2013
@jezdez jezdez merged commit ed096dc into jazzband:master Sep 9, 2013
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
pombredanne pushed a commit to pombredanne/django-authority that referenced this pull request Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants